linux-kernel - Re: [regression] e1000e broke e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080411085907.GA10801@elte.hu>
Date:	Fri, 11 Apr 2008 10:59:07 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Bill Davidsen <davidsen@....com>
Cc:	Matthew Wilcox <matthew@....cx>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Jeff Garzik <jeff@...zik.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	NetDev <netdev@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Greg KH <greg@...ah.com>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [regression] e1000e broke e1000


* Bill Davidsen <davidsen@....com> wrote:

>> the solution is rather straightforward: if E1000 is built-in then 
>> E1000E should be built-in as well or disabled (i.e. it should not be 
>> possible to build it as a module in that case) - because the PCI ID 
>> stealing trick now connects the two drivers unconditionally. [ If 
>> e1000 is a module then e1000e can be a module (or disabled) - this 
>> would be the most common configuration. ]
>
> And this would seem to break the most common means of testing a new 
> driver for existing (and working!) hardware, which is to build both 
> drivers as modules, install the new one, and if it appears to have 
> problems either remove and insert the old driver by hand, or boot 
> forcing the old driver.
>
> I can't be the only person who tests kernels on machines I wouldn't 
> use to build a kernel, and uses modprobe.conf to test new driver 
> functionality.

yes, but note that the breakage you are talking about is not caused my 
patch, it is caused by the planned change to remove those PCI IDs from 
e1000.

my suggested change only solves part of the more general problem you 
touch upon. (and it does not make it worse in any way)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/