linux-kernel - Re: [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tkrat.d9db3519cd83e9ff@s5r6.in-berlin.de>
Date:	Sat, 12 Apr 2008 18:14:37 +0200 (CEST)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets

I wrote:
> --- linux.orig/drivers/firewire/fw-ohci.c
> +++ linux/drivers/firewire/fw-ohci.c
> @@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
>  	if (unlikely(evt >= ARRAY_SIZE(evts)))
>  			evt = 0x1f;
>  
> -	if (header[0] == ~header[1]) {
> +	if (header[1] == ~header[2]) {
>  		printk(KERN_DEBUG "A%c %s, %s, %08x\n",
> -		       dir, evts[evt], phys[header[0] >> 30 & 0x3],
> -		       header[0]);
> +		       dir, evts[evt], phys[header[1] >> 30 & 0x3],
> +		       header[1]);

This patch is bogus.  The indices were right.
-- 
Stefan Richter
-=====-==--- -=-- -==--
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/