linux-kernel - Re: pci: add to global list before sysfs?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2008 07:35:38 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Pierre Ossman <drzeus-list@...eus.cx>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: pci: add to global list before sysfs?

On Fri, 2008-04-04 at 14:01 -0700, Greg KH wrote:
> As I mention above, the "global list" is now gone, so it's going to be
> a
> bit harder to do this.  We now only keep one list of all PCI devices,
> and that is with the driver core mechanisms as the duplicate list was
> just sitting there doing nothing for the past 4 years.
> 
> So is the problem that your driver need to bind to multiple pci
> devices
> at the same time in order to work properly?
> 
> Or is this just really broken hardware?

Haven't had a chance to look at your changes yet, but I have memories of
being pretty happy with having that 2 step mechanism in PCI where the
driver core would only see the devices after fixup.

The reason for that is powerpc, like many other archs, need to do all
sorts of fixups before devices get used by drivers. Resources need to be
fixed up, interrupts, etc...

A lot of that happens in pcibios_fixup_bus() and we did rely on having
no driver bound before that happens. The binding can only happen after
the arch calls pci_bus_add_devices().

Is that still the case ? If not, then there is some big potential
breakage here and we need to look closely at re-organizing the way we do
our fixups.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/