linux-kernel - Re: *_pagetable_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2008 11:31:46 +0200
From:	Jacek Luczak <difrost.kernel@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	ijc@...lion.org.uk, tglx@...utronix.de,
	LKML <linux-kernel@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: *_pagetable_setup_[start,done] crap ?

Ingo Molnar pisze:
> * Jacek Luczak <difrost.kernel@...il.com> wrote:
> 
>> Ohh... and prototypes are wrong:
>> diff --git a/include/asm-x86/pgtable_32.h b/include/asm-x86/pgtable_32.h
>> index 6cbc520..2167879 100644
>> --- a/include/asm-x86/pgtable_32.h
>> +++ b/include/asm-x86/pgtable_32.h
>> @@ -204,8 +204,8 @@ do {                                                \
>>   */
>>  #define update_mmu_cache(vma, address, pte) do { } while (0)
>>
>> -void native_pagetable_setup_start(pgd_t *base);
>> -void native_pagetable_setup_done(pgd_t *base);
>> +extern void native_pagetable_setup_start(pgd_t *base) __init;
>> +extern void native_pagetable_setup_done(pgd_t *base) __init;
> 
> while generally it's nice to add 'extern' to prototypes, it's not an 
> outright bug to not have it. Also, __init is a must-have in the 
> definition only - it should not be added to the prototype.
> 

Sounds reasonably. Sorry for calling something crap. When I slept well it looks fine and clear for me.

-Jacek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/