linux-kernel - Re: [patch 2/2] bootmem: Node-setup agnostic free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zlry6mzx.fsf@saeurebad.de>
Date:	Sun, 13 Apr 2008 12:57:22 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	linux-kernel@...r.kernel.org, "Andi Kleen" <ak@...e.de>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Yasunori Goto" <y-goto@...fujitsu.com>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	"Christoph Lameter" <clameter@....com>
Subject: Re: [patch 2/2] bootmem: Node-setup agnostic free_bootmem()

Hi,

"Yinghai Lu" <yhlu.kernel@...il.com> writes:

> On Sat, Apr 12, 2008 at 3:33 PM, Johannes Weiner <hannes@...urebad.de> wrote:
>> Make free_bootmem() look up the node holding the specified address
>>  range which lets it work transparently on single-node and multi-node
>>  configurations.
>>
>>  Signed-off-by: Johannes Weiner <hannes@...urebad.de>
>>  CC: Yinghai Lu <yhlu.kernel@...il.com>
>>  CC: Andi Kleen <ak@...e.de>
>>  CC: Yasunori Goto <y-goto@...fujitsu.com>
>>  CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>>  CC: Ingo Molnar <mingo@...e.hu>
>>  CC: Christoph Lameter <clameter@....com>
>>  CC: Andrew Morton <akpm@...ux-foundation.org>
>>  ---
>>
>>  Patch tested on x86_32 uma.
>>
>>  Index: linux-2.6/mm/bootmem.c
>>  ===================================================================
>>  --- linux-2.6.orig/mm/bootmem.c
>>  +++ linux-2.6/mm/bootmem.c
>>  @@ -421,7 +421,15 @@ int __init reserve_bootmem(unsigned long
>>
>>   void __init free_bootmem(unsigned long addr, unsigned long size)
>>   {
>>  -       free_bootmem_core(NODE_DATA(0)->bdata, addr, size);
>>  +       bootmem_data_t *bdata;
>>  +
>>  +       list_for_each_entry (bdata, &bdata_list, list) {
>>  +               if (addr < bdata->node_boot_start)
>>  +                       continue;
>
> could have chance that bootmem with reserved_early that is crossing
> the nodes.

Upstream reserve_bootmem_core() would BUG() on a caller trying to cross
nodes, so I don't see where this chance could come from.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/