linux-kernel - Re: [PATCH 2/2] printk: Remember the message level for multi-line output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414080351.GL16163@elte.hu>
Date:	Mon, 14 Apr 2008 10:03:51 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Nick Andrew <nick@...k-andrew.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, joe@...ches.com
Subject: Re: [PATCH 2/2] printk: Remember the message level for multi-line
	output


* Nick Andrew <nick@...k-andrew.net> wrote:

> printk: Remember the message level for multi-line output
> 
> printk(KERN_ALERT "Danger Will Robinson!\nAlien Approaching!\n");
> 
> At present this will result in one message at ALERT level and one at 
> the current default message loglevel (e.g. WARNING). This is 
> non-intuitive.
> 
> Modify vprintk() to remember the message loglevel each time it is 
> specified and use it for subsequent lines of output which do not 
> specify one, within the same call to printk.

i've applied this too for testing.

but multi-line strings are a bit unclean i think: each message line 
should have its separate printk.

will your patch leave the behavior of multiple calls to printk alone? 
I.e. if i do:

  printk(KERN_ALERT "Danger Will Robinson!\n");
  printk("Alien Approaching!\n");

then we'll still get a KERN_ALERT plus a default printk, right? In that 
case my earlier observation about this patch is moot and i guess it's 
fine to do this.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/