linux-kernel - Re: [2.6 patch] mtd/cmdlinepart.c: don't compare pointers with 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080414161037.GZ6695@cs181133002.pp.htv.fi>
Date:	Mon, 14 Apr 2008 19:10:38 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] mtd/cmdlinepart.c: don't compare pointers with 0

On Mon, Apr 14, 2008 at 06:42:11PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> Adrian Bunk wrote:
>
>> Sparse spotted that 0 was compared to pointers.
>
>> While I was at it, I also moved the assignments out of the if's.
>
>> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
>> 32de76e83f37322dd85eaecf126e7b17327f606f diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
>> index b44292a..3e09043 100644
>> --- a/drivers/mtd/cmdlinepart.c
>> +++ b/drivers/mtd/cmdlinepart.c
>> @@ -119,7 +119,8 @@ static struct mtd_partition * newpart(char *s,
>>  		char *p;
>>   	    	name = ++s;
>> -		if ((p = strchr(name, delim)) == 0)
>> +		p = strchr(name, delim);
>> +		if (!p)
>>  		{
>
>    Wouldn't it be nice to join the standalone brace to if () while it?

Most of the file is written like this, so there's no point in changing 
it only here...

>>  			printk(KERN_ERR ERRP "no closing %c found in partition name\n", delim);
>>  			return NULL;
>
> WBR, Sergei

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/