linux-kernel - Re: x86: ppc fixes for find_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1208191719.12568.1247788911@webmail.messagingengine.com>
Date:	Mon, 14 Apr 2008 18:48:39 +0200
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Alexander van Heukelum" <heukelum@...lshack.com>,
	linux-kernel@...r.kernel.org
Subject: Re: x86: ppc fixes for find_first_bit

Hello Thomas,

I see Ingo has applied three fixes to the x86-tree:
    find_first_bit() ppc fix
    powerpc: fix powerpc build
    find_next_bit() fix

Could you please give some insight in what went wrong with
ppc and powerpc?

"find_first_bit() ppc fix" disables the use of find_first_bit
for every user of GENERIC_FIND_NEXT_BIT=y. It replaces it by a
macro to call find_next_bit with offset=0. It should be possible
for an arch to use GENERIC_FIND_NEXT_BIT=y and implement 
find_first_bit by itself.

"powerpc: fix powerpc build" removes the private 'implementation'
of asm-generic/bitops/find.h. It seems correct code to me. What
was the problem here? If it is duplicate declarations, then
I would suggest putting #ifndef GENERIC_FIND_NEXT_BIT around
them.

"find_next_bit() fix" changes asm-generic/bitops/find.h to
declare find_next_bit only if CONFIG_GENERIC_FIND_NEXT_BIT=n.
That is indeed a good change. It would be better if this
file disappeared completely, though.

Greetings,
    Alexander
-- 
  Alexander van Heukelum
  heukelum@...tmail.fm

-- 
http://www.fastmail.fm - One of many happy users:
  http://www.fastmail.fm/docs/quotes.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/