linux-kernel - Re: [PATCH 1/2] fix sys_unshare()+SEM_UNDO: add support for CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414211801.GA676@sergelap.austin.ibm.com>
Date:	Mon, 14 Apr 2008 16:18:01 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"Serge E. Hallyn" <serue@...ibm.com>, manfred@...orfullife.com,
	linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
	xemul@...nvz.org, sukadev@...ibm.com
Subject: Re: [PATCH 1/2] fix sys_unshare()+SEM_UNDO: add support for
	CLONE_SYSVSEM

Quoting Andrew Morton (akpm@...ux-foundation.org):
> On Mon, 14 Apr 2008 09:58:40 -0500
> "Serge E. Hallyn" <serue@...ibm.com> wrote:
> 
> > Quoting Manfred Spraul (manfred@...orfullife.com):
> > > Andrew Morton wrote:
> > >> On Sun, 13 Apr 2008 10:04:17 +0200 Manfred Spraul 
> > >> <manfred@...orfullife.com> wrote:
> > >>
> > >>> sem_undo_list **new_ulistp)
> > >>>  {
> > >>> -	if (unshare_flags & CLONE_SYSVSEM)
> > >>> -		return -EINVAL;
> > >>> +	if (unshare_flags & CLONE_SYSVSEM) {
> > >>> +		*new_ulistp = (void*)1;
> > >>> +	}
> > >>>     
> > >>
> > >> And can we do anything nicer than this?
> > >>
> > >>   
> > > Attached is an alternative. If you prefer it, I'll send another patch set.
> > 
> > FWIW I definately far far prefer this version  :)
> 
> Oh, OK.
> 
> I guess I'll drop what I have.  Manfred, can we please have a new patchset?
> 
> We might end up slipping this back to 2.6.25.1.  Would that be a bad thing?

It'd be unfortunate, but as the existing patch doesn't completely fix
the problem it's probably best to wait anyway.

Manfred, I don't want to step on your toes, but please do let me know if
you don't have time to do the next version.  If you do have time, then
thank you again for spotting+fixing the problem.

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/