linux-kernel - Re: [2.6 patch] add include/asm-avr32/xor.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0804141450x51d93a5eh38a5144f5e6ec0f1@mail.gmail.com>
Date:	Mon, 14 Apr 2008 17:50:10 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Sebastian Siewior" <linux-crypto@...breakpoint.cc>
Cc:	"Adrian Bunk" <bunk@...nel.org>, hskinnemoen@...el.com,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	shannon.nelson@...el.com, dan.j.williams@...el.com
Subject: Re: [2.6 patch] add include/asm-avr32/xor.h

On Mon, Apr 14, 2008 at 5:46 PM, Sebastian Siewior
<linux-crypto@...breakpoint.cc> wrote:
> * Adrian Bunk | 2008-04-14 21:15:36 [+0300]:
>  >> >601f75e99c076c16e2648f4860cac4fc6ce187ea diff --git a/include/asm-avr32/xor.h b/include/asm-avr32/xor.h
>  >> >new file mode 100644
>  >> >index 0000000..99c87aa
>  >> >--- /dev/null
>  >> >+++ b/include/asm-avr32/xor.h
>  >> >@@ -0,0 +1,6 @@
>  >> >+#ifndef _ASM_XOR_H
>  >> >+#define _ASM_XOR_H
>  >> >+
>  >> >+#include <asm-generic/xor.h>
>  >> >+
>  >> >+#endif
>  >>
>  >> What about providing <linux/xor.h> which includes the right file from
>  >> asm/ or asm-generic/ depending on HAVE_.* ?
>  >
>  >Where's the advantage?
>
>  This week you are going through avr32. The same fixup is required for
>  blackfin or cris if my ls isn't lying. So either you fix every arch
>  with this missing include or you provide a generic include and every
>  arch that provides a private xor.h includes it. From what I can see
>  almost every arch includes the generic except for x86 & sparc so most
>  xor.h files are identical copies and this is probably as bad as a
>  trailing white space :)

indeed.  the less work for arches the better :).
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/