linux-kernel - Re: [PATCH] drivers/atm/horizon.c: stop inlining largish static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080413.215452.31407494.davem@davemloft.net>
Date:	Sun, 13 Apr 2008 21:54:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vda.linux@...glemail.com
Cc:	chas@....nrl.navy.mil, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/atm/horizon.c: stop inlining largish static
 functions

From: Denys Vlasenko <vda.linux@...glemail.com>
Date: Tue, 8 Apr 2008 12:21:42 +0200

> drivers/atm/horizon.c has unusually large number
> of static inline functions - 36.
> 
> I looked through them. Most of them seems to be small enough,
> but a few are big, others are using udelay or busy loop,
> and as such are better not be inlined.
> 
> This patch removes "inline" from these static functions
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
> 
> Size difference for 32bit x86:
>    text    data     bss     dec     hex filename
>    8201     180       6    8387    20c3 linux-2.6-ALLYES/drivers/atm/horizon.o
>    7840     180       6    8026    1f5a linux-2.6.inline-ALLYES/drivers/atm/horizon.o
> 
> Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>

Applied to net-2.6.26, thanks Denys.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/