linux-kernel - Re: [PATCH-mm 11/15] video: Use get/put_unaligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414230557.GD9785@ZenIV.linux.org.uk>
Date:	Tue, 15 Apr 2008 00:05:57 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH-mm 11/15] video: Use get/put_unaligned_* helpers

On Mon, Apr 14, 2008 at 03:48:00PM -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  drivers/video/matrox/matroxfb_misc.c |   28 ++++++++++++++--------------
>  drivers/video/metronomefb.c          |    9 +++------
>  2 files changed, 17 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/video/matrox/matroxfb_misc.c b/drivers/video/matrox/matroxfb_misc.c
> index ab7fb50..cfb5205 100644
> --- a/drivers/video/matrox/matroxfb_misc.c
> +++ b/drivers/video/matrox/matroxfb_misc.c
> @@ -522,8 +522,6 @@ static void parse_bios(unsigned char __iomem* vbios, struct matrox_bios* bd) {
>  #endif
>  }
>  
> -#define get_u16(x) (le16_to_cpu(get_unaligned((__u16*)(x))))
> -#define get_u32(x) (le32_to_cpu(get_unaligned((__u32*)(x))))

Why not simply change definitions of those?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/