[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080414071800.GE16163@elte.hu>
Date: Mon, 14 Apr 2008 09:18:00 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Heiko Carstens <heiko.carstens@...ibm.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Miles Lane <miles.lane@...il.com>,
LKML <linux-kernel@...r.kernel.org>,
Gautham Shenoy <ego@...ibm.com>,
"Rafael J. Wysocki" <rjw@...k.pl>,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: 2.6.25-rc9 -- INFO: possible circular locking dependency
detected
* Heiko Carstens <heiko.carstens@...ibm.com> wrote:
> On Mon, Apr 14, 2008 at 08:54:05AM +0200, Peter Zijlstra wrote:
> > Fun,
> >
> > I will need to sort out this code before I can say anything about that,
> > perhaps Gautham and or Rafael have ideas before I can come up with
> > something.. ?
>
> Why not simply removing the get/put_online_cpus() pair in
> sched_getaffinity? It's superfluous since we have already a
> read_lock/read_unlock pair there which does disable/enable cpu hotplug
> anyway.
we dont want to insert such silent "preempt off == hotplug disable"
assumptions - which assumption breaks when the tasklist_lock becomes
preemptible (such as in -rt).
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists