linux-kernel - Re: [PATCH 4/8] rfkill: add read-write rfkill switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804150827.49936.carlos@strangeworlds.co.uk>
Date:	Tue, 15 Apr 2008 08:27:49 +0100
From:	Carlos Corbacho <carlos@...angeworlds.co.uk>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Ivo van Doorn <ivdoorn@...il.com>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	linux-kernel@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 4/8] rfkill: add read-write rfkill switch support

On Monday 14 April 2008 21:23:14 Dmitry Torokhov wrote:
> On Mon, Apr 14, 2008 at 08:06:50PM +0100, Carlos Corbacho wrote:
> > I agree wholeheartedly with Henrique here though - wireless drivers
> > should _not_ be using key press events as a reporting mechanism.
>
> Reporting mechanism for what exacly though? Depending on what you are
> talking about we either agree or disagree here ;)

Reporting state change in this case. For instance, KEY_WLAN means exactly 
that - a user pressed a key that was mapped to KEY_WLAN. It's not a generic 
notifier for any and all wireless events, state changes, etc.

If wireless drivers want to report a state change, then we need a proper 
mechanism for that, as has already been discussed by Henrique.

-Carlos
-- 
E-Mail: carlos@...angeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/