linux-kernel - Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080415.010131.156668601.davem@davemloft.net>
Date:	Tue, 15 Apr 2008 01:01:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	vgusev@...nvz.org, kuznet@....inr.ac.ru,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue

From: Andi Kleen <andi@...stfloor.org>
Date: Tue, 15 Apr 2008 09:59:40 +0200

> Vitaliy Gusev <vgusev@...nvz.org> writes:
> 
> > Hello!
> >
> > tcp_prune_queue() doesn't prune an out-of-order queue at all.
> 
> Why are you saying this? It has code to prune the ooo queue. You're even
> moving it in your patch.
> 
> You're saying that the code doesn't work? If yes why? 

There are inappropriate guards there, and it didn't get invoked
from another important code path.

That's what his change is fixing.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/