linux-kernel - Re: mm/page_alloc.c: remove hand-coded get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080415023505.2c5eac5f.akpm@linux-foundation.org>
Date:	Tue, 15 Apr 2008 02:35:05 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Pavel Machek <pavel@....cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: mm/page_alloc.c: remove hand-coded get_order()

On Tue, 15 Apr 2008 11:23:27 +0200 Pavel Machek <pavel@....cz> wrote:

> 
> __get_free_pages() is strange interface:
> 
> It has underscores, yet get_free_pages() does not exists.
> 
> It returns long when most people need pointer.

It is a bit odd.

> (And it takes order, when many people want to pass size).
> 
> What about creating void *get_free_pages(flags, order) version,

Sounds sensible.  It matches free_pages().

> then slowly converting users to it?

alas, poor me.

> 
> ---
> 
> Remove hand-coded get_order() from page_alloc.c.
> 
> Signed-off-by: Pavel Machek <pavel@...e.cz>
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 402a504..c48aa45 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4339,9 +4339,7 @@ void *__init alloc_large_system_hash(con
>  		else if (hashdist)
>  			table = __vmalloc(size, GFP_ATOMIC, PAGE_KERNEL);
>  		else {
> -			unsigned long order;
> -			for (order = 0; ((1UL << order) << PAGE_SHIFT) < size; order++)
> -				;
> +			unsigned long order = get_order(size);
>  			table = (void*) __get_free_pages(GFP_ATOMIC, order);
>  			/*
>  			 * If bucketsize is not a power-of-two, we may free
> 

OK.  get_order() does round up, doesn't it?  We seem to have forgotten to
document that rather important detail.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/