linux-kernel - Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804151429270.17123@wrl-59.cs.helsinki.fi>
Date:	Tue, 15 Apr 2008 14:37:56 +0300 (EEST)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Adrian Bunk <bunk@...nel.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] smb.h: uses struct timespec but didn't include	linux/time.h

On Tue, 15 Apr 2008, Adrian Bunk wrote:

> On Tue, Apr 15, 2008 at 02:10:57AM -0700, Andrew Morton wrote:
> > On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@...sinki.fi> wrote:
> > >  
> > > +#include <linux/time.h>
> > 
> > Did this actually cause a compilation error?
> 
> Even if it doesn't at the moment it should be fixed - these kind
> of issues are why often adding or removing an #include in a header 
> suddenly breaks some configuration on some other architecture.

...I suppose point of Andrew's enquiry was more about determining how 
soon it should be scheduled for inclusion rather than its usefulness.

-- 
 i.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/