linux-kernel - Re: [PATCH 0/5] call_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080414184544.16ae4123.akpm@linux-foundation.org>
Date:	Mon, 14 Apr 2008 18:45:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	mathieu.desnoyers@...ymtl.ca, mingo@...e.hu, hch@...radead.org,
	mmlnx@...ibm.com, dipankar@...ibm.com, dsmith@...hat.com,
	rostedt@...dmis.org, adrian.bunk@...ial.fi, a.p.zijlstra@...llo.nl,
	ego@...ibm.com, niv@...ibm.com, dvhltc@...ibm.com,
	rusty@....ibm.com, jkenisto@...ux.vnet.ibm.com, oleg@...sign.ru,
	jamesclhuang@...oo.com
Subject: Re: [PATCH 0/5] call_rcu_sched() series

On Mon, 14 Apr 2008 18:33:12 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Sun, 13 Apr 2008 20:58:48 -0700 "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:
> 
> > This series adds call_rcu_sched(), applies some fixes to RCU Classic,
> > adds rcu_barrier_sched(), updates rcutorture, and updates the RCU
> > documentation.
> 
> Some massaging was needed here to make these apply against the
> RCU changes in git-sched.
> 
> All fairly simple, except I don't know if these:
> 
> static inline void rcu_enter_nohz(void)
> {
> 	smp_mb(); /* CPUs seeing ++ must see prior RCU read-side crit sects */
> 	__get_cpu_var(rcu_dyntick_sched).dynticks++;
> 	WARN_ON(__get_cpu_var(rcu_dyntick_sched).dynticks & 0x1);
> }
> 
> static inline void rcu_exit_nohz(void)
> {
> 	__get_cpu_var(rcu_dyntick_sched).dynticks++;
> 	smp_mb(); /* CPUs seeing ++ must see later RCU read-side crit sects */
> 	WARN_ON(!(__get_cpu_var(rcu_dyntick_sched).dynticks & 0x1));
> }
> 
> in include/linux/rcupreempt.h ended up the way we want them?

argh, I see.  It's all tangled up with the WARN_ON_SECS stuff.

Let me try to straighten it all out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/