linux-kernel - Re: [PATCH] tty: The big operations rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080415053706.GD23965@kroah.com>
Date:	Mon, 14 Apr 2008 22:37:06 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] tty: The big operations rework

On Sun, Apr 13, 2008 at 06:40:11PM +0100, Alan Cox wrote:
> - Operations are now a shared const function block as with most other
> Linux objects
> - Introduce wrappers for some optional functions to get consistent
> behaviour
> - Wrap put_char which used to be patched by the tty layer
> - Document which functions are needed/optional
> - Make put_char report success/fail
> - Cache the driver->ops pointer in the tty as tty->ops
> - Remove various surplus lock calls we no longer need
> - Remove proc_write method as noted by Alexey Dobriyan
> - Introduce some missing sanity checks where certain driver/ldisc
> combinations would oops as they didn't check needed methods were present
> 
> Signed-off-by: Alan Cox <alan@...hat.com>

Very nice, thanks for plugging away on this rework, it's really
appreciated.

If you want, you can add:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
to the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/