linux-kernel - Re: Shutdown and Reboot Regression 2.6.25-rc[78]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200804152150.25060.bonganilinux@mweb.co.za>
Date:	Tue, 15 Apr 2008 21:50:24 +0200
From:	Bongani Hlope <bonganilinux@...b.co.za>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Shutdown and Reboot Regression 2.6.25-rc[78]

On Monday 14 April 2008 17:09:41 Linus Torvalds wrote:
> On Mon, 14 Apr 2008, Linus Torvalds wrote:
> > Since you cannot see this on -rc9, can you go back to -rc8 and test this
> > patch [...]
>
> Oh, maybe I should actually include the patch too ;)
>
> 			Linus
> ---
>  kernel/printk.c |   16 ++++++++++++++--
>  1 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index c46a20a..4476879 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -643,8 +643,20 @@ static int
> acquire_console_semaphore_for_printk(unsigned int cpu) {
>  	int retval = 0;
>
> -	if (can_use_console(cpu))
> -		retval = !try_acquire_console_sem();
> +	if (!try_acquire_console_sem()) {
> +		retval = 1;
> +
> +		/*
> +		 * If we can't use the console, we need to release
> +		 * the console semaphore by hand to avoid flushing
> +		 * the buffer
> +		 */
> +		if (!can_use_console(cpu)) {
> +			console_locked = 0;
> +			up(&console_sem);
> +			retval = 0;
> +		}
> +	}
>  	printk_cpu = UINT_MAX;
>  	spin_unlock(&logbuf_lock);
>  	return retval;
> --

Sorry for the late response, we have a electric situation in the country, the 
patch fixes the problem for me (tested on rc8).

Thanx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/