| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Apr 2008 22:15:34 +0200 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: Sam Ravnborg <sam@...nborg.org> Cc: Adrian Bunk <bunk@...nel.org>, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org, Russell King <rmk@....linux.org.uk> Subject: Re: [2.6 patch] PCMCIA mustn't select HAVE_IDE On Monday 14 April 2008, Sam Ravnborg wrote: > On Mon, Apr 14, 2008 at 05:16:59PM +0300, Adrian Bunk wrote: > > It's plain wrong for PCMCIA to select HAVE_IDE that implies e.g. the > > availability of an asm/ide.h > > > > Signed-off-by: Adrian Bunk <bunk@...nel.org> > > > > --- > > 9cdb66112488bc0c6e1d528444d3ba30d5b0487f diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig > > index 8b22281..519b4ff 100644 > > --- a/drivers/pcmcia/Kconfig > > +++ b/drivers/pcmcia/Kconfig > > @@ -38,7 +38,6 @@ config PCMCIA_DEBUG > > config PCMCIA > > tristate "16-bit PCMCIA support" > > select CRC32 > > - select HAVE_IDE > > default y > > I did this when introducing HAVE_IDE. > But I do not recall why and the rationale for removing it > seems fine to me. IIRC it was needed for some arm platforms which don't select HAVE_IDE explicetely but I don't know if this is still the case, pinging Russell. > So patch looks good - but I have not investigated in detail. > > Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists