linux-kernel - Re: [PATCH] tty: fix routine name in ptmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080415150143.e19bb518.akpm@linux-foundation.org>
Date:	Tue, 15 Apr 2008 15:01:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	linux-kernel@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] tty: fix routine name in ptmx_open()

On Mon, 14 Apr 2008 17:55:49 -0700
Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:

> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> 
> At ptmx_open(), the 2nd parameter for check_tty_count() should
> be "ptmx_open".
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> ---
>  drivers/char/tty_io.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index 613ec81..546217d 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
>  	if (devpts_pty_new(tty->link))
>  		goto out1;
>  
> -	check_tty_count(tty, "tty_open");
> +	check_tty_count(tty, "ptmx_open");
>  	retval = ptm_driver->open(tty, filp);
>  	if (!retval) {
>  		tty_audit_opening();

Of course, using __func__ prevents this sort of bitrot.

Or even #define check_tty_count(tty) __check_tty_count(tty, __func__)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/