linux-kernel - Re: gart: factor out common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed10ee420804151625i1e30abb7r98ddda53ec6e8da6@mail.gmail.com>
Date:	Tue, 15 Apr 2008 16:25:29 -0700
From:	"SL Baur" <steve@...acs.org>
To:	"Pavel Machek" <pavel@....cz>
Cc:	"kernel list" <linux-kernel@...r.kernel.org>,
	"Andi Kleen" <andi@...stfloor.org>, "Ingo Molnar" <mingo@...e.hu>
Subject: Re: gart: factor out common code

On 4/15/08, Pavel Machek <pavel@....cz> wrote:
> Cleanup gart handling on amd64 a bit: move common code into
>  enable_gart_translation , and use symbolic register names where
>  appropriate.
>
>  Signed-off-by: Pavel Machek <pavel@...e.cz>

Which source tree is this patch against?  I'm looking at Linus
latest and I don't see the AMD64_* constants defined in the
same place.

Other reviewer comments:
The casting between struct pci_dev * and u64 is kind of ugly,
I presume the reason for the narrowing casts in the block of
code you moved is documented somewhere.

It looks OK as far as I can see, but I'm not looking at the same
source code, so I don't think I should add a Reviewed-by:.

-sb
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/