linux-kernel - Re: [PATCH 2/7] omfs: add inode routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2008 19:56:59 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/7] omfs: add inode routines

On Tue, Apr 15, 2008 at 08:30:59PM +0200, Marcin Slusarz wrote:
> > +	if (be32_to_cpu(omfs_sb->s_magic) != OMFS_MAGIC) {
> 
> can be omfs_sb->s_magic != cpu_to_be32(OMFS_MAGIC)
> (cpu_to_be32 can be optimized away even on LE)

Good point, I'll change that.

> > +	if (bh)
> > +		brelse(bh);
> brelse(NULL) is safe to call

Yup, I saw that too.  I dropped these and added the labels per Miklos'
suggestion.

> > +	return ret;
> > +}
> 
> this code leaks omfs_sbi_info (sbi)

This one I'm not seeing.  FS core calls put_super if ret is nonzero so
this should be ok?

Thanks!
-- 
Bob Copeland %% www.bobcopeland.com 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/