linux-kernel - Re: [PATCH] proc: convert /proc/tty/ldiscs to seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080414233816.22d9be53.akpm@linux-foundation.org>
Date:	Mon, 14 Apr 2008 23:38:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH] proc: convert /proc/tty/ldiscs to seq_file interface

On Sun, 13 Apr 2008 00:59:23 +0400 Alexey Dobriyan <adobriyan@...il.com> wrote:

> @@ -224,7 +239,6 @@ void __init proc_tty_init(void)
>  	 * entry.
>  	 */
>  	proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
> -
> -	create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
> +	proc_create("tty/ldiscs", 0, NULL, &tty_ldiscs_proc_fops);
>  	proc_create("tty/drivers", 0, NULL, &proc_tty_drivers_operations);
>  }

hm.  proc_tty_init() used to check for _some_ procfs API failures.  Now it
doesn't do any checking at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/