linux-kernel - Re: + bootmem-node-setup-agnostic-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <86802c440804150002t2abd5532wddcce6304fe991fb@mail.gmail.com>
Date:	Tue, 15 Apr 2008 00:02:29 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	akpm@...ux-foundation.org
Cc:	mm-commits@...r.kernel.org, hannes@...urebad.de, ak@...e.de,
	clameter@....com, kamezawa.hiroyu@...fujitsu.com, mingo@...e.hu,
	y-goto@...fujitsu.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: + bootmem-node-setup-agnostic-free_bootmem.patch added to -mm tree

On Mon, Apr 14, 2008 at 11:23 PM,  <akpm@...ux-foundation.org> wrote:
>
>  The patch titled
>      bootmem: node-setup agnostic free_bootmem()
>  has been added to the -mm tree.  Its filename is
>      bootmem-node-setup-agnostic-free_bootmem.patch
>
>  Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
>  *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
>  See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
>  out what to do about this
>
>  The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
>  ------------------------------------------------------
>  Subject: bootmem: node-setup agnostic free_bootmem()
>  From: Johannes Weiner <hannes@...urebad.de>
>
>  Make free_bootmem() look up the node holding the specified address range which
>  lets it work transparently on single-node and multi-node configurations.
>
>  Signed-off-by: Johannes Weiner <hannes@...urebad.de>
>  Cc: Yinghai Lu <yhlu.kernel@...il.com>
>  Acked-by: Andi Kleen <ak@...e.de>
>  Cc: Yasunori Goto <y-goto@...fujitsu.com>
>  Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>  Cc: Ingo Molnar <mingo@...e.hu>
>  Cc: Christoph Lameter <clameter@....com>
>  Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>  ---
>
>   mm/bootmem.c |   10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
>  diff -puN mm/bootmem.c~bootmem-node-setup-agnostic-free_bootmem mm/bootmem.c
>  --- a/mm/bootmem.c~bootmem-node-setup-agnostic-free_bootmem
>  +++ a/mm/bootmem.c
>  @@ -421,7 +421,15 @@ int __init reserve_bootmem(unsigned long
>
>   void __init free_bootmem(unsigned long addr, unsigned long size)
>   {
>  -       free_bootmem_core(NODE_DATA(0)->bdata, addr, size);
>  +       bootmem_data_t *bdata;
>  +
>  +       list_for_each_entry (bdata, &bdata_list, list) {
>  +               if (addr < bdata->node_boot_start)
>  +                       continue;
>  +               free_bootmem_core(bdata, addr, size);
>  +               return;
>  +       }
>  +       BUG();
>   }

NAK,
it doesn't solve the cross nodes bootmem that is reserved via
reserve_early. like ramdisk free in x86/setup_64.c
...
                        free_bootmem(ramdisk_image, ramdisk_size);
                        printk(KERN_ERR "initrd extends beyond end of memory "
                               "(0x%08lx > 0x%08lx)\ndisabling initrd\n",
                               ramdisk_end, end_of_mem);
                        initrd_start = 0;
..
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/