| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080416105851.GB1621@elf.ucw.cz> Date: Wed, 16 Apr 2008 12:58:55 +0200 From: Pavel Machek <pavel@....cz> To: Vitaliy Ivanov <vitalivanov@...il.com> Cc: Andrew Morton <akpm@...l.org>, kernel list <linux-kernel@...r.kernel.org>, marcel@...tmann.org, maxk@...lcomm.com, linux-bluetooth@...r.kernel.org Subject: Re: hci_usb: remove macro code obfuscation On Wed 2008-04-16 13:51:37, Vitaliy Ivanov wrote: > On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@....cz> wrote: > > > > I had trouble figuring out what the code does. atomic_inc/dec > > management is actually pretty simple, but it is needlessly obfuscated > > with macros. Fix that. > > > > Signed-off-by: Pavel Machek <pavel@...e.cz> > > > > I had trouble figuring out what the code does. atomic_inc/dec > > management is actually pretty simple, but it is needlessly obfuscated > > with macros. Fix that. > > > > Signed-off-by: Pavel Machek <pavel@...e.cz> > > > Got it from the first time;) > > Do you think that now code looks better? As for me it's not... Yes. Hiding & operator deep inside macro is evil for one thing. Plus it is no longer clear what the code does with the macros in there. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists