linux-kernel - [PATCH] firewire: fix sourceID read from wrong quadlet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <408349802.26451@ustc.edu.cn>
Date:	Wed, 16 Apr 2008 20:43:22 +0800
From:	"" <jszhang3@...l.ustc.edu.cn>
To:	krh@...hat.com
Cc:	stefanr@...6.in-berlin.de, linux-kernel@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net
Subject: [PATCH] firewire: fix sourceID read from wrong quadlet

>From JiSheng Zhang <jszhang3@...l.ustc.edu.cn>

In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI 
specification, section 8.7.1).

--- linux-2.6.24.4/drivers/firewire/fw-transaction.c.orig    2008-04-14
20:57:48.294718721 +0800
+++ linux-2.6.24.4/drivers/firewire/fw-transaction.c    2008-04-14
20:58:07.083525930 +0800
@@ -650,7 +650,7 @@ fw_core_handle_request(struct fw_card *c
          HEADER_GET_OFFSET_HIGH(p->header[1]) << 32) | p->header[2];
     tcode       = HEADER_GET_TCODE(p->header[0]);
     destination = HEADER_GET_DESTINATION(p->header[0]);
-    source      = HEADER_GET_SOURCE(p->header[0]);
+    source      = HEADER_GET_SOURCE(p->header[1]);
 
     spin_lock_irqsave(&address_handler_lock, flags);
     handler = lookup_enclosing_address_handler(&address_handler_list,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/