lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Apr 2008 16:02:33 +0200 From: Ingo Molnar <mingo@...e.hu> To: Mel Gorman <mel@....ul.ie> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/4] Make defencive checks around PFN values registered for memory usage * Mel Gorman <mel@....ul.ie> wrote: > + if (*start_pfn > max_sparsemem_pfn) { > + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation", > + "Start of range %lu -> %lu exceeds SPARSEMEM max %lu\n", > + *start_pfn, *end_pfn, max_sparsemem_pfn); small request: please emit a WARN_ON_ONCE() as well, so that kerneloops.org (and automated test setups) picks it up. > + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation", > + "End of range %lu -> %lu exceeds SPARSEMEM max %lu\n", > + *start_pfn, *end_pfn, max_sparsemem_pfn); ditto - all errors should be fixed up and we should try to continue as far as possible, but emitting a WARN_ON_ONCE() will be very useful in making sure people notice the warning. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists