linux-kernel - Re: [PATCH -mm] relayfs: support larger relay buffer take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804162110070.19171@sbz-30.cs.Helsinki.FI>
Date:	Wed, 16 Apr 2008 21:21:09 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	Masami Hiramatsu <mhiramat@...hat.com>
cc:	Tom Zanussi <zanussi@...cast.net>,
	David Wilder <dwilder@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	systemtap-ml <systemtap@...rces.redhat.com>,
	LKML <linux-kernel@...r.kernel.org>, tzanussi@...il.com
Subject: Re: [PATCH -mm] relayfs: support larger relay buffer take 2

Hi Masami,

On Wed, 16 Apr 2008, Masami Hiramatsu wrote:
> +static struct page *relay_alloc_page_array(unsigned int n_pages)
> +{
> +	struct page *array;
> +	unsigned int pa_size = n_pages * sizeof(struct page *);
> +
> +	if (pa_size > PAGE_SIZE) {
> +		array = vmalloc(pa_size);
> +		if (array)
> +			memset(array, 0, pa_size);
> +	} else {
> +		array = kcalloc(n_pages, sizeof(struct page *), GFP_KERNEL);
> +	}
> +	return array;
> +}

I think it's bit confusing to have relay_alloc_page_array() return a 
pointer to struct page as it's really allocating an _array_ of pointers to 
struct page. So why not just use void * here as the kernel memory 
allocators do?

> +static void relay_free_page_array(struct page *array)
> +{
> +	if (is_vmalloc_addr(array))
> +		vfree(array);
> +	else
> +		kfree(array);
> +}

Here as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/