linux-kernel - Re: hci_usb: remove macro code obfuscation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080416112909.505fe619.akpm@linux-foundation.org>
Date:	Wed, 16 Apr 2008 11:29:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Vitaliy Ivanov" <vitalivanov@...il.com>
Cc:	pavel@....cz, linux-kernel@...r.kernel.org, marcel@...tmann.org,
	maxk@...lcomm.com, linux-bluetooth@...r.kernel.org
Subject: Re: hci_usb: remove macro code obfuscation

On Wed, 16 Apr 2008 13:51:37 +0300
"Vitaliy Ivanov" <vitalivanov@...il.com> wrote:

> On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@....cz> wrote:
> >
> >  I had trouble figuring out what the code does. atomic_inc/dec
> >  management is actually pretty simple, but it is needlessly obfuscated
> >  with macros. Fix that.
> >
> >  Signed-off-by: Pavel Machek <pavel@...e.cz>
> >
> >  I had trouble figuring out what the code does. atomic_inc/dec
> >  management is actually pretty simple, but it is needlessly obfuscated
> >  with macros. Fix that.
> >
> >  Signed-off-by: Pavel Machek <pavel@...e.cz>
> 
> 
> Got it from the first time;)
> 
> Do you think that now code looks better? As for me it's not...
> 

Yes, I expect that the original code was easier to work with and it is not
obfuscated I don't think.  Sometimes these things take a few minutes for
new readers to become comfortable with but are good for people who work on
the code regularly.

Although it's a mystery why __pending_tx() and friends

a) have leading underscores and

b) are implemented in cpp, when C is available.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/