linux-kernel - RE: [patch] cciss: fix warning oops on rmmod of driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DEE40752C8AF224BB890E455C7B8E0FE0452BDC314@G6W0268.americas.hpqcorp.net>
Date:	Wed, 16 Apr 2008 19:18:16 +0000
From:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
To:	"scameron@...rdog.cca.cpqcorp.net" <scameron@...rdog.cca.cpqcorp.net>,
	Jens Axboe <jens.axboe@...cle.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mikem@...rdog.cca.cpqcorp.net" <mikem@...rdog.cca.cpqcorp.net>
Subject: RE: [patch] cciss: fix warning oops on rmmod of driver



> -----Original Message-----
> From: scameron@...rdog.cca.cpqcorp.net
> [mailto:scameron@...rdog.cca.cpqcorp.net]
> Sent: Wednesday, April 16, 2008 2:01 PM
> To: Jens Axboe
> Cc: linux-kernel@...r.kernel.org; Miller, Mike (OS Dev);
> mikem@...rdog.cca.cpqcorp.net
> Subject: [patch] cciss: fix warning oops on rmmod of driver
>
>
> * Fix oops on cciss rmmod due to calling pci_free_consistent with
>   irqs disabled.
>
> Signed-off-by: Stephen M. Cameron <scameron@...rdog.cca.cpqcorp.net>

Acked-by: Mike Miller <mike.miller@...com>

> ---
>
>  linux-2.6.25-rc9/drivers/block/cciss_scsi.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN
> linux-2.6.25-rc9/drivers/block/cciss_scsi.c~pci_free_consisten
> t_oops linux-2.6.25-rc9/drivers/block/cciss_scsi.c
> ---
> root/linux-2.6.25-rc9/drivers/block/cciss_scsi.c~pci_free_cons
> istent_oops   2008-04-16 12:58:53.000000000 -0500
> +++ root-root/linux-2.6.25-rc9/drivers/block/cciss_scsi.c
>   2008-04-16 12:59:22.000000000 -0500
> @@ -1349,9 +1349,9 @@ cciss_unregister_scsi(int ctlr)
>         /* set scsi_host to NULL so our detect routine will
>            find us on register */
>         sa->scsi_host = NULL;
> +       spin_unlock_irqrestore(CCISS_LOCK(ctlr), flags);
>         scsi_cmd_stack_free(ctlr);
>         kfree(sa);
> -       spin_unlock_irqrestore(CCISS_LOCK(ctlr), flags);
>  }
>
>  static int
> _
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/