linux-kernel - Re: 2.6.25 and DEBUG_SECTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080416205230.GA4129@uranus.ravnborg.org>
Date:	Wed, 16 Apr 2008 22:52:30 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Adrian Bunk <bunk@...nel.org>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.25 and DEBUG_SECTION_MISMATCH

On Wed, Apr 16, 2008 at 09:55:04PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > * Sam Ravnborg <sam@...nborg.org> wrote:
> > 
> > > I would prefer we were down to less than 5 warnings so we could 
> > > enable it in kconfig but maybe after next merge window.
> > 
> > they get regenerated. More than 1 out of every 100 new patches. Quite 
> > expensive feature (in terms of maintenance overhead) for a rather 
> > theoretical memory saving benefit.
> 
> in v2.6.24 we had at least 200 section fixes:
> 
>   $ git-log v2.6.24.. | egrep -c 'WARNING:.*Section mismatch'
>   198
> 
> for 12671 commits - that's 1 section type fix for every 60 commits.
Please get your numbers right. What you count is the number of
Section mismatch warnings that has been fixed.
Sometime fixing up one line of code fixes >5 section mismatch warnings.

> and 90% of the problems could be reduced via the very simple patch below 
> ...
> 
> so ... why shouldnt we say that if someone wants to have this feature, 
> it should be done all automatically, in the link space. There's no 
> reason why the dependencies couldnt be figured out all automatically.

Or we could fix the blatant misuse of __cpuinit. If has
replaced a proper separation of code that is only relevant for
CPU hotplug and code that is used with and without CPUHOTPLUG.

I question that we have 580 functions that is used duing init in
normal cases and during CPU hotplug.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/