linux-kernel - Re: [patch] mm: sparsemem memory_present() memory corruption fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080416112015.79ac4867.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 16 Apr 2008 11:20:15 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Christoph Lameter" <clameter@....com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, "Mel Gorman" <mel@....ul.ie>,
	"Nick Piggin" <npiggin@...e.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, apw@...dowen.org
Subject: Re: [patch] mm: sparsemem memory_present() memory corruption fix

On Tue, 15 Apr 2008 19:00:18 -0700
"Yinghai Lu" <yhlu.kernel@...il.com> wrote:

> On Tue, Apr 15, 2008 at 6:30 PM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> >
> > On Tue, Apr 15, 2008 at 6:17 PM, Ingo Molnar <mingo@...e.hu> wrote:
> >  >
> >  >  * Ingo Molnar <mingo@...e.hu> wrote:
> >  >
> >  >  > > > this is the only call to memory_present() we do in 32-bit arch
> >  >  > > > setup, so it's required.
> >  >  > >
> >  >  > > We could clip there if SPARSEMEM is configured. I wonder if this
> >  >  > > affects other platforms that need HIGHMEM support?
> >  >  >
> >  >  > clip where and what?
> >  >
> >  >  i.e. as per my previous argument i'd consider the need to sanitize the
> >  >  calls in the architecture fundamentally wrong.
> >  >
> >  >  whether the core code emits a warning or allows the call is an
> >  >  additional question i mention in the changelog - but the core sparse
> >  >  memory code should _definitely_ not silently overflow a key internal
> >  >  array ... (of which data structure the architecture code is not even
> >  >  aware of)
> >
> >  or you can move that check into find_max_pfn for x86_32? so it will
> >  not affect other platform regarding Christoph's concern?
> >
> the patch doesn't have side effects on x86_64.
> 
also no side effects on my ia64/NUMA box, which has sparse physical memory map.

Thanks,
-Kame



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/