linux-kernel - Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080416222755.GA18832@alpha.franken.de>
Date:	Thu, 17 Apr 2008 00:27:56 +0200
From:	tsbogend@...ha.franken.de (Thomas Bogendoerfer)
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	ralf@...ux-mips.org, linux-mips@...ux-mips.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno()

On Wed, Apr 16, 2008 at 05:09:58PM +0200, Roel Kluin wrote:
> Thomas Bogendoerfer wrote:
> > On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
> >> irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,
>  
> >> +		if ((int) irq < 0)
> > 
> > Why don't you just make irq and rt_timer_irq an int ?
> 
> Ok, thanks, It should be right, but I cannot test this (no hardware).

I've tested it on real hardware.

Acked-By: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/