linux-kernel - Re: [PATCH 2/6] MIPS: ip27-timer: fix unsigned irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080416091554.GA6026@alpha.franken.de>
Date:	Wed, 16 Apr 2008 11:15:54 +0200
From:	tsbogend@...ha.franken.de (Thomas Bogendoerfer)
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	ralf@...ux-mips.org, linux-mips@...ux-mips.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] MIPS: ip27-timer: fix unsigned irq < 0

On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
> irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,
>     
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---   
> diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
> index 25d3baf..3c08afd 100644
> --- a/arch/mips/sgi-ip27/ip27-timer.c
> +++ b/arch/mips/sgi-ip27/ip27-timer.c
> @@ -222,19 +222,19 @@ static void __init hub_rt_clock_event_global_init(void)
>  	unsigned int irq;
>  
>  	do {
>  		smp_wmb();
>  		irq = rt_timer_irq;
>  		if (irq)
>  			break;
>  
>  		irq = allocate_irqno();
> -		if (irq < 0)
> +		if ((int) irq < 0)

Why don't you just make irq and rt_timer_irq an int ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/