linux-kernel - Re: [PATCH 36/48] [GFS2] fix file_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080417115848.GA8642@lst.de>
Date:	Thu, 17 Apr 2008 13:58:48 +0200
From:	Christoph Hellwig <hch@....de>
To:	swhiteho@...hat.com
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 36/48] [GFS2] fix file_system_type leak on gfs2meta mount

On Thu, Apr 17, 2008 at 09:39:12AM +0100, swhiteho@...hat.com wrote:
> From: Christoph Hellwig <hch@....de>
> 
> get_gfs2_sb does a get_fs_type without doing a put_filesystem and
> thus leaking a file_system_type reference everytime it's called.
> 
> Just use gfs2_fs_type directly instead of doing the lookup and thus
> fix the problem.

Btw, after this patch we should remove the get_fs_type export.  It's
not used by modules and because put_filesystem is not exported every
modular user would fundamentally have the same leak as the one fixed in
this patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/