linux-kernel - Re: [PATCH update] firewire: fw-ohci: work around generation bug in TI controllers (fix AV/C and more)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4807D374.8090608@s5r6.in-berlin.de>
Date:	Fri, 18 Apr 2008 00:47:16 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jarod Wilson <jwilson@...hat.com>
CC:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH update] firewire: fw-ohci: work around generation bug
 in	TI controllers (fix AV/C and more)

Jarod Wilson wrote:
> On Saturday 12 April 2008 04:31:25 pm Stefan Richter wrote:
>> +	ohci->bus_reset_packet_quirk = dev->vendor == PCI_VENDOR_ID_TI;
>> +
> 
> I have a few cards with PCI_VENDOR_ID_CREATIVE with a TI TSB41AB2 chip on 'em 
> (SoundBlaster Audigy w/FireWire port). I've not had any issues on any of the 
> cards I've got, but do we want to add them to the work-around list just to be 
> safe?

No, we don't need to.  TSB41AB2 is only a PHY, not a link layer 
controller.  While the PHYs (the combination of PHYs which are present 
on the bus) influence the conditions under which the bug can happen, the 
cause for the bug is in the link layer controller alone.

So unless Creative used a TI design in their link layer controller or 
otherwise managed to implement this same quirk as TI (Agere, NEC, and 
VIA didn't according to my tests so far), the presence of TSB41AB2 on a 
card does not make it necessary to activate the quirk workaround.
-- 
Stefan Richter
-=====-==--- -=-- =--=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/