linux-kernel - Re: [PATCH -mm] relayfs: support larger relay buffer take 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1208405128.8701.42.camel@charm-linux>
Date:	Wed, 16 Apr 2008 23:05:28 -0500
From:	Tom Zanussi <tzanussi@...il.com>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Pekka J Enberg <penberg@...helsinki.fi>,
	David Wilder <dwilder@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	systemtap-ml <systemtap@...rces.redhat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm] relayfs: support larger relay buffer take 3


On Wed, 2008-04-16 at 15:51 -0400, Masami Hiramatsu wrote:
> Use vmalloc() and memset() instead of kcalloc() to allocate a page* array
> when the array size is bigger than one page. This enables relayfs to support
> bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...hat.com>
> ---
> Changes from take2 to take3:
>  - Use struct page ** instead of struct page *.
>  - move functions to the place before relay_mmap_buf.
>  - add comments.
> 
> This is useful for a 64-bit system which has a plenty of memory (tens of
> giga bytes) and a large kernel memory space.
> 
> I tested it on x86-64 and ia64.
> 

Hi,

Looks fine to me.

Reviewed-by: Tom Zanussi <tzanussi@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/