linux-kernel - Re: 2.6.25-mm1: not looking good

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804181057.12246.paul.moore@hp.com>
Date:	Fri, 18 Apr 2008 10:57:12 -0400
From:	Paul Moore <paul.moore@...com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mingo@...e.hu, tglx@...utronix.de, penberg@...helsinki.fi,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, jmorris@...ei.org, sds@...ho.nsa.gov
Subject: Re: 2.6.25-mm1: not looking good

On Thursday 17 April 2008 9:35:38 pm Andrew Morton wrote:
> I dropped git-selinux and that crash seems to have gone away.  It
> took about five minutes before, but would presumably have happened
> earlier if I'd reduced the cache size.
>
> btw, wouldn't this
>
> --- a/security/selinux/netnode.c~a
> +++ a/security/selinux/netnode.c
> @@ -190,7 +190,7 @@ static int sel_netnode_insert(struct sel
>  	if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
>  		struct sel_netnode *tail;
>  		tail = list_entry(node->list.prev, struct sel_netnode, list);
> -		list_del_rcu(node->list.prev);
> +		list_del_rcu(&tail->list);
>  		call_rcu(&tail->rcu, sel_netnode_free);
>  	} else
>  		sel_netnode_hash[idx].size++;
> _
>
> be a bit clearer?  If it's correct - I didn't try too hard :)

Looks good to me, although before I fix this let me try and figure out 
why this code is causing the machine to puke all over itself.  
Priorities you know :)

-- 
paul moore
linux @ hp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/