linux-kernel - Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080418131149.ZZRA012@mailhub.coreip.homeip.net>
Date:	Fri, 18 Apr 2008 13:15:58 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	khali@...ux-fr.org, andre@...wigglers.org,
	linux-input@...r.kernel.org, i2c@...sensors.org,
	linux-kernel@...r.kernel.org, vapier.adi@...il.com,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick
	driver (v2)

Hi Bryan,

On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote:
> +	input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) |
> +						BIT_MASK(BTN_BASE2) |
> +						BIT_MASK(BTN_BASE3) |
> +						BIT_MASK(BTN_BASE4);
> +	input->keybit[BIT_WORD(KEY_UP)] |=  BIT_MASK(KEY_UP) |
> +						BIT_MASK(KEY_DOWN) |
> +						BIT_MASK(KEY_LEFT) |
> +						BIT_MASK(KEY_RIGHT);
> +

Why don't you use REL_X/REL_Y to report directional movement? Using
buttons for that is pretty unusual.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/