linux-kernel - Re: [PATCH sched-devel] ftrace: trace_entries to change trace buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080418121431.7f1c05f1.akpm@linux-foundation.org>
Date:	Fri, 18 Apr 2008 12:14:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Pekka Paalanen <pq@....fi>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Soeren Sandmann Pedersen <sandmann@...hat.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH sched-devel] ftrace: trace_entries to change trace
 buffer size

On Fri, 18 Apr 2008 08:48:09 -0400 (EDT) Steven Rostedt <rostedt@...dmis.org> wrote:

> > > +		data->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> > > +		max_tr.data[i]->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> >
> > eww.  This *really* needs explanatory comments.
> >
> 
> Actually, that's just a way of doing spin_lock_init for raw spin locks. I
> didn't see any other way.

Maybe we need raw_spin_lock_init().  And DEFINE_RAW_SPINLOCK()?

Although it isn't a great idea to be encouraging the use of raw 
spinlocks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/