linux-kernel - Re: [PATCH] memcgroup: check and initialize page->cgroup in memmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48081224.3080208@cn.fujitsu.com>
Date:	Fri, 18 Apr 2008 11:14:44 +0800
From:	Shi Weihua <shiwh@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
CC:	akpm@...ux-foundation.org, balbir@...ux.vnet.ibm.com,
	xemul@...nvz.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	hugh@...itas.com
Subject: Re: [PATCH] memcgroup: check and initialize page->cgroup in memmap_init_zone

KAMEZAWA Hiroyuki wrote::
> On Fri, 18 Apr 2008 10:46:30 +0800
> Shi Weihua <shiwh@...fujitsu.com> wrote:
> 
>> In this patch, the Author Hugh Dickins said 
>> "...memmap_init_zone doesn't need it either, ...
>> Linux assumes pointers in zeroed structures are NULL pointers."
>> But it seems it's not always the case, so we should check and initialize
>> page->cgroup anyways.
>>
> Hmm...strange. (I never see this with 2.6.25 + Primequest) 
> What memory model are you using ? CONFIG_SPRASEMEM_VMEMMAP ?

It's CONFIG_DISCONTIGMEM_MANUAL.
BTW, I attached the .config file. pls check it.

Thanks,
-Shi

View attachment ".config" of type "text/plain" (35845 bytes)