linux-kernel - Re: [PATCH 1/5] ftrace: simple clean ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080418131535.dbcd315d.akpm@linux-foundation.org>
Date:	Fri, 18 Apr 2008 13:15:35 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, rostedt@...dmis.org,
	peterz@...radead.org, sandmann@...hat.com, pq@....fi,
	srostedt@...hat.com
Subject: Re: [PATCH 1/5] ftrace: simple clean ups

On Fri, 18 Apr 2008 16:05:39 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> -	r = snprintf(buf, 64, "%ld\n",
> +	r = snprintf(buf, sizeof(buf), "%ld\n",

If you use scnprintf here

>  		     *ptr == (unsigned long)-1 ? -1 : nsecs_to_usecs(*ptr));
> -	if (r > 64)
> -		r = 64;
> +	if (r > sizeof(buf))
> +		r = sizeof(buf);

This becomes a cant-happen (I think).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/