linux-kernel - Re: [PATCH 3/3] slub: add hooks for kmemcheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48092CFC.9090708@cs.helsinki.fi>
Date:	Sat, 19 Apr 2008 02:21:32 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Christoph Lameter <clameter@....com>
CC:	Vegard Nossum <vegard.nossum@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] slub: add hooks for kmemcheck

Hi,

Christoph Lameter wrote:
>>>  Should this not go into some kmemcheck.h file?
>> The implementations of these prototypes are in mm/slub_kmemcheck.c.
>> They are only ever called from slub.c since they represent the
>> interface between SLUB and kmemcheck.
>>
>> Would you rather have it in include/linux/slub_kmemcheck.h?
> 
> Well lets see what Pekka says.

Well, I've tried to push for "generic" kmemcheck hooks so that they can 
be used by SLAB/SLOB too but Vegard has always talked me out of it. Of 
course, I have long forgotten the rationale.

But anyway, slub_kmemcheck.h sounds okay and I wonder if we should put 
it in mm/ instead of include/linux/ as it's not supposed to be included 
by anyone except SLUB?

Christoph Lameter wrote:
>> Currently, with SLAB/SLUB debugging enabled, the page flag will be
>> cleared, then accessed in check_object(), thus generating a few
>> accesses to the page. It is safer to delay the clearing of the page
>> flag until no more accesses can be generated for the page.
> 
> Hmmmm.. Okay that is already dealt with by a patch in Pekka's tree.

And merged by Linus now.

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/