[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <86802c440804172206k7533e7d1kf1f355f6a97a4412@mail.gmail.com>
Date: Thu, 17 Apr 2008 22:06:22 -0700
From: "Yinghai Lu" <yhlu.kernel@...il.com>
To: "Johannes Weiner" <hannes@...urebad.de>
Cc: "Ingo Molnar" <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
"Linux MM" <linux-mm@...ck.org>,
"Andi Kleen" <andi@...stfloor.org>,
"Yasunori Goto" <y-goto@...fujitsu.com>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
"Christoph Lameter" <clameter@....com>,
"Andrew Morton" <akpm@...ux-foundation.org>,
"Siddha, Suresh B" <suresh.b.siddha@...el.com>
Subject: Re: [RFC][patch 2/5] mm: Node-setup agnostic free_bootmem()
On Wed, Apr 16, 2008 at 12:17 PM, Johannes Weiner <hannes@...urebad.de> wrote:
> Hi,
>
>
>
> Ingo Molnar <mingo@...e.hu> writes:
>
> > * Yinghai Lu <yhlu.kernel@...il.com> wrote:
> >
> >> > Yes, it should work well with cross nodes case.
> >> >
> >> > but please add boundary check on free_bootmem_node too.
> >>
> >> also please note: it will have problem span nodes box.
> >>
> >> for example: node 0: 0-2g, 4-6g, node1: 2-4g, 6-8g. and if ramdisk sit
> >> creoss 2G boundary. you will only free the range before 2g.
> >
> > yes. Such systems _will_ become more common - so the "this is rare"
> > arguments are incorrect. bootmem has to be robust enough to deal with
> > it.
>
> Ingo, I never doubted any of this, I was just asking more than once if
> and when this might happen. And I don't want the allocator become
> fragile, just not completely ignorant about bogus input.
>
> But the situation is still not clear for me. Ingo, how are these
> node spanning pfn ranges represented in the kernel? How many node
> descriptors will you have in the case Yinghai described and how will
> they look like?
according to patch from Suresh in x86.git, one node still only have one bdata.
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists