linux-kernel - Re: [PATCH] usb-serial: option: Don't match Huawei driver CD images

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1208498494.14194.28.camel@hermes2.karcher.local>
Date:	Fri, 18 Apr 2008 08:01:34 +0200
From:	Michael Karcher <kernel@...rcher.dialup.fu-berlin.de>
To:	Greg KH <greg@...ah.com>
Cc:	smurf@...rf.noris.de, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb-serial: option: Don't match Huawei driver CD images

Am Donnerstag, den 17.04.2008, 20:24 -0700 schrieb Greg KH:
> What is this patch against?  We have a change that went into 2.6.25
> after 2.6.25-rc9 that should make this patch not be needed.
The patch is developed against 2.6.25-rc8 + some git patches, but I have
forward-ported it to current git.

I *guess* you are talking about commit aad8a278 (USB: support more
Huawei data card product IDs), as I could not find . The header of this
patch talks about three changes (declaration of unusual devices,
disabling product ID matching in driver.c and finally declaring the
product in option.c). I find only the first and the last point if this
reflected in the patch, and there are *no* patches at all to
drivers/usb/core/driver.c in the timeframe you mentioned. This patch
addresses the second point of that list, but in another way.

The problem is that those huawei products have four USB interfaces,
three usb-serial like interfaces handled by the option driver and a
fourth one to be handled by usb-storage. When the stick gets initially
plugged, only the mass storage device is visible and needs a magic kick
to expose the other interfaces. aad8a278 contains a valid and working
patch to kick those USB devices if the mass storage interface gets bound
by usb-storage. At least in 2.6.25-rc8, if the option module is loaded,
the mass storage device gets bound to the option driver instead that
exposes a useless and non-functional serial interface on the mass
storage endpoint. This prevents the usb-storage driver to perform the
needed kicking.

> Can you try that release and verify this?
I will try with a current git kernel without my patch and report back,
but I will be surprised if the problem described above is gone. System
is currently compiling.

> thanks,
You're welcome.

Kind regards,
  Michael Karcher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/