linux-kernel - Re: [PATCH 01/15] ARM minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Apr 2008 18:17:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	rmk@....linux.org.uk, linux-arm-kernel@...ts.arm.linux.org.uk,
	kernel@...tstofly.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/15] ARM minor irq handler cleanups

On Fri, 18 Apr 2008 20:21:07 -0400 Jeff Garzik <jeff@...zik.org> wrote:

> Andrew Morton wrote:
> > On Fri, 18 Apr 2008 19:22:45 -0400 (EDT)
> > Jeff Garzik <jeff@...zik.org> wrote:
> > 
> >> Avoid confusion by /not/ passing an unused pointer to
> >> arm_rtc_interrupt()
> >>
> >> This change's main purpose is to prepare for the patchset in
> >> jgarzik/misc-2.6.git#irq-remove, that explores removal of the
> >> never-used 'irq' argument in each interrupt handler.
> > 
> > #irq-remove doesn't seem to be included in the #ALL branch which
> > I'm grabbing?
> 
> I certainly welcome the exposure.......  but it would be a huge pain for 
> you IMO because of the constant breakage.
> 

wow.

 1084 files changed, 2363 insertions(+), 1934 deletions(-)

I didn't realise you'd changed all the interrupt handlers too.  Good luck
with that :)

Is it a flag day or do we have a migration plan?  I'd have thought that we
could do a request_irq_new(irqreturn_t (*)(void *d)) and keep things
compatible?

<checks>

Actually, that tree applies reasonably sanely to the full -mm lineup. 
There are rejects of course, but they're easily fixed and a lot are due to
file motion which git will handle anyway,

The bigger problem is newly-added irq handlers which your patch doesn't
know about:

y:/usr/src/25> grep '^+.*request_irq[(]' patches/*.patch | wc -l
74

If we had a migration plan (ie: request_irq_new(), above) then this of
course wouldn't be a problem.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/