linux-kernel - Re: [GIT PATCH] SCSI updates for 2.6.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080419164202.GA28328@elte.hu>
Date:	Sat, 19 Apr 2008 18:42:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [GIT PATCH] SCSI updates for 2.6.25


* James Bottomley <James.Bottomley@...senPartnership.com> wrote:

> >  drivers/built-in.o: In function `sas_request_addr':
> >  : undefined reference to `release_firmware'
> > 
> > config can be found at:
> > 
> >    http://redhat.com/~mingo/misc/config-Sat_Apr_19_16_58_35_CEST_2008.bad
> > 
> > ... brought to you by x86.git's randconfig build and boot service ;-)
> 
> This one's fun.  The root cause is 
> 
> CONFIG_SCSI_SAS_LIBSAS=y
> CONFIG_FW_LOADER=m
> 
> The problem is that libsas doesn't depend on the FW loader and doesn't 
> want to.  It just wants to use it if it's available.  The definitions 
> in include/linux/firmware.h have stubs to facilitate this.
> 
> However, CONFIG_FW_LOADER=m defeats the stubs.
> 
> This is a bit nasty to fix; however, I think this patch does.  I've 
> also put a large comment in to explain what's going on.
> 
> Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>

thanks James - your fix works fine here.

Tested-by: Ingo Molnar <mingo@...e.hu>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/