| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4809573E.4010406@sgi.com> Date: Fri, 18 Apr 2008 19:21:50 -0700 From: Mike Travis <travis@....com> To: Andrew Morton <akpm@...ux-foundation.org> CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: x86: clean up non-smp usage of cpu maps Andrew Morton wrote: > On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote: > >> x86: clean up non-smp usage of cpu maps >> >> Cleanup references to the early cpu maps for the non-SMP configuration >> and remove some functions called for SMP configurations only. >> >> ... >> >> index 1179aa0..dc79409 100644 >> --- a/arch/x86/kernel/setup.c >> +++ b/arch/x86/kernel/setup.c >> @@ -10,7 +10,7 @@ >> #include <asm/setup.h> >> #include <asm/topology.h> >> >> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA >> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP) > > This implies that we can have > > CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP > > which a) appears to be true and b) seems rather dumb? Yeah, I kind of picked that up in a code merge and didn't really look at it too closely. I should have checked the Kconfig file to make sure that it couldn't inadvertently get set if SMP is not set. Thanks, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists